fix(legacy): modernTargets should set build.target
#20393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
plugin: legacy
p4-important
bluwy
previously approved these changes
Jul 16, 2025
bluwy
reviewed
Jul 16, 2025
packages/plugin-legacy/README.md
Outdated
| - **Default:** [`'edge>=79, firefox>=67, chrome>=64, safari>=12, chromeAndroid>=64, iOS>=12'`](https://browsersl.ist/#q=edge%3E%3D79%2C+firefox%3E%3D67%2C+chrome%3E%3D64%2C+safari%3E%3D12%2C+chromeAndroid%3E%3D64%2C+iOS%3E%3D12) | ||
|
|
||
| If explicitly set, it's passed on to [`@babel/preset-env`](https://babeljs.io/docs/en/babel-preset-env#targets) when rendering **modern chunks**. | ||
| It's passed on to [`@babel/preset-env`](https://babeljs.io/docs/en/babel-preset-env#targets) when collecting polyfills for **modern chunks**. |
There was a problem hiding this comment.
Maybe we should also now mention that this field overrides build.target always.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
bluwy
approved these changes
Aug 7, 2025
sapphi-red
deleted the
fix/legacy-modern-targets-should-set-build-target
branch
axeloradmin
pushed a commit
to axelor/axelor-open-platform
that referenced
this pull request
Sep 17, 2025
Due to vitejs/vite#20393, a warning message is printed during the build and it fails. Signed-off-by: Pierre Belloy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
modernTargetsoption is when collecting polyfills for modern chunks. On the other hand,build.targetoption is used when lowering by esbuild for modern chunks.This means these two options should be synced. When
renderLegacyChunksistrue, these two were synced. The value ofmodernTargetswere converted and set tobuild.target.But when
renderLegacyChunksisfalse, that did not happen. This causes more / less polyfills to be injected than needed.This PR makes the legacy plugin to set
build.targetto the value converted frommodernTargetsoption.This will cause
build.targetto be set to a lower version in applications that didn't setmodernTargetsoption (before['chrome107', 'edge107', 'firefox104', 'safari16'], after['es2020', 'edge79', 'firefox67', 'chrome64', 'safari12']).The alternative is to set
modernTargetsbased onbuild.target. This will makemodernTargetsoption no-op. Also we need to make a function that converts esbuild target syntax to browserslist syntax.refs #15506